Merged
Conversation
…nProviderTestSuite This is done because that test suite fails from time to time, this is to test if the bundle cache cleaning has anything to do with this.
This is to prevent possible entries added because of multiple bundle event being handled.
This reverts commit 960a9d0.
…alizationProviderTestSuite" This reverts commit c7e75f8.
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 67.83% 68.34% +0.51%
==========================================
Files 127 127
Lines 26375 26908 +533
==========================================
+ Hits 17891 18390 +499
- Misses 8484 8518 +34
Continue to review full report at Codecov.
|
abroekhuis
reviewed
Jun 11, 2020
abroekhuis
approved these changes
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pubsub utils tests fail from time to time. The PR fixes that issue. I have rerun several time to ensure to issues is not triggered anymore.